[node-red] Add startupProbe (#147)

* Add startupProbe to Node-RED chart in order to address slow starting container being killed due to liveness probe failures.

* Bump node-red chart version

* Update version to reflect new feature.

* Paramaterisation of liveness, readiness and startup probe configuration.

Configure startup probe to disabled by default.

Co-authored-by: Jeff Billimek <jeff@billimek.com>

charts/bazarr/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v0.9.0.5
 description: Bazarr is a companion application to Sonarr and Radarr. It manages and downloads subtitles based on your requirements
 name: bazarr
-version: 4.3.0
+version: 4.4.0
 keywords:
   - bazarr
   - radarr
@@ -21,4 +21,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/jackett/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v0.16.2106
 description: API Support for your favorite torrent trackers
 name: jackett
-version: 5.3.0
+version: 5.4.0
 keywords:
   - jackett
   - torrent
@@ -17,4 +17,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/lidarr/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 0.8.0.1886
 description: Looks and smells like Sonarr but made for music
 name: lidarr
-version: 5.3.0
+version: 5.4.0
 keywords:
   - lidarr
   - torrent
@@ -18,4 +18,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/node-red/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 1.0.6-12
 description: Node-RED is low-code programming for event-driven applications
 name: node-red
-version: 3.1.0
+version: 3.2.0
 keywords:
   - nodered
   - node-red

charts/node-red/README.md

@@ -36,46 +36,58 @@ The command removes all the Kubernetes components associated with the chart and
 
 The following tables lists the configurable parameters of the Node-RED chart and their default values.
 
-| Parameter                          | Description                                                             | Default                   |
-|:---------------------------------- |:----------------------------------------------------------------------- |:------------------------- |
-| `image.repository`                 | node-red image                                                          | `nodered/node-red`        |
-| `image.tag`                        | node-red image tag                                                      | `1.0.6-12-minimal`        |
-| `image.pullPolicy`                 | node-red image pull policy                                              | `IfNotPresent`            |
-| `strategyType`                     | Specifies the strategy used to replace old Pods by new ones             | `Recreate`                |
-| `serviceAccountName`               | Service account to run the pod as                                       | ``                        |
-| `livenessProbePath`                | Default livenessProbe path                                              | `/`                       |
-| `readinessProbePath`               | Default readinessProbe path                                             | `/`                       |
-| `flows`                            | Default flows configuration                                             | `flows.json`              |
-| `safeMode`                         | Setting to true starts Node-RED in safe (not running) mode              | `false`                   |
-| `enableProjects`                   | setting to true starts Node-RED with the projects feature enabled       | `false`                   |
-| `nodeOptions`                      | Node.js runtime arguments                                               | ``                        |
-| `extraEnvs`                        | Extra environment variables which will be appended to the env           | `[]`                      |
-| `timezone`                         | Default timezone                                                        | `UTC`                     |
-| `service.type`                     | Kubernetes service type for the GUI                                     | `ClusterIP`               |
-| `service.port`                     | Kubernetes port where the GUI is exposed                                | `1880`                    |
-| `service.nodePort`                 | Kubernetes nodePort where the GUI is exposed                            | ``                        |
-| `service.annotations`              | Service annotations for the GUI                                         | `{}`                      |
-| `service.labels`                   | Custom labels                                                           | `{}`                      |
-| `service.loadBalancerIP`           | Loadbalance IP for the GUI                                              | `{}`                      |
-| `service.loadBalancerSourceRanges` | List of IP CIDRs allowed access to load balancer (if supported)         | None                      |
-| `service.externalTrafficPolicy`    | Set the externalTrafficPolicy in the Service to either Cluster or Local | `Cluster`                 |
-| `ingress.enabled`                  | Enables Ingress                                                         | `false`                   |
-| `ingress.annotations`              | Ingress annotations                                                     | `{}`                      |
-| `ingress.path`                     | Ingress path                                                            | `/`                       |
-| `ingress.hosts`                    | Ingress accepted hostnames                                              | `chart-example.local`     |
-| `ingress.tls`                      | Ingress TLS configuration                                               | `[]`                      |
-| `persistence.enabled`              | Use persistent volume to store data                                     | `false`                   |
-| `persistence.size`                 | Size of persistent volume claim                                         | `5Gi`                     |
-| `persistence.existingClaim`        | Use an existing PVC to persist data                                     | `nil`                     |
-| `persistence.storageClass`         | Type of persistent volume claim                                         | `-`                       |
-| `persistence.accessModes`          | Persistence access modes                                                | `ReadWriteOnce`           |
-| `persistence.subPath`              | Mount a sub dir of the persistent volume                                | `nil`                     |
-| `resources`                        | CPU/Memory resource requests/limits                                     | `{}`                      |
-| `nodeSelector`                     | Node labels for pod assignment                                          | `{}`                      |
-| `tolerations`                      | Toleration labels for pod assignment                                    | `[]`                      |
-| `affinity`                         | Affinity settings for pod assignment                                    | `{}`                      |
-| `podAnnotations`                   | Key-value pairs to add as pod annotations                               | `{}`                      |
-| `deploymentAnnotations`            | Key-value pairs to add as deployment annotations                        | `{}`                      |
+| Parameter                             | Description                                                             | Default                   |
+|:------------------------------------- |:----------------------------------------------------------------------- |:------------------------- |
+| `image.repository`                    | node-red image                                                          | `nodered/node-red`        |
+| `image.tag`                           | node-red image tag                                                      | `1.0.6-12-minimal`        |
+| `image.pullPolicy`                    | node-red image pull policy                                              | `IfNotPresent`            |
+| `strategyType`                        | Specifies the strategy used to replace old Pods by new ones             | `Recreate`                |
+| `serviceAccountName`                  | Service account to run the pod as                                       | ``                        |
+| `probes.liveness.enabled`             | Enable/ disable livenessProbe                                           | `true`                    |
+| `probes.liveness.probePath`           | Set livenessProbe path                                                  | `/`                       |
+| `probes.liveness.initialDelaySeconds` | Set livenessProbe initial delay                                         | 60                        |
+| `probes.liveness.failureThreshold`    | Set livenessProbe failure threshold                                     | 5                         |
+| `probes.liveness.timeoutSeconds`      | Set livenessProbe timeout                                               | 10                        |
+| `probes.readiness.enabled`            | Enable/ disable readinessProbe                                          | `true`                    |
+| `probes.readiness.probePath`          | Set readinessProbe path                                                 | `/`                       |
+| `probes.readiness.initialDelaySeconds`| Set readinessProbe initial delay                                        | 60                        |
+| `probes.readiness.failureThreshold`   | Set readinessProbe failure threshold                                    | 5                         |
+| `probes.readiness.timeoutSeconds`     | Set readinessProbe timeout                                              | 10                        |
+| `probes.startup.enabled`              | Enable/ disable readinessProbe                                          | `false`                   |
+| `probes.startup.probePath`            | Set startupProbe path                                                   | `/`                       |
+| `probes.startup.failureThreshold`     | Set startupProbe failure threshold                                      | 30                        |
+| `probes.startup.periodSeconds`        | Set startupProbe period                                                 | 10                        |
+| `flows`                               | Default flows configuration                                             | `flows.json`              |
+| `safeMode`                            | Setting to true starts Node-RED in safe (not running) mode              | `false`                   |
+| `enableProjects`                      | setting to true starts Node-RED with the projects feature enabled       | `false`                   |
+| `nodeOptions`                         | Node.js runtime arguments                                               | ``                        |
+| `extraEnvs`                           | Extra environment variables which will be appended to the env           | `[]`                      |
+| `timezone`                            | Default timezone                                                        | `UTC`                     |
+| `service.type`                        | Kubernetes service type for the GUI                                     | `ClusterIP`               |
+| `service.port`                        | Kubernetes port where the GUI is exposed                                | `1880`                    |
+| `service.nodePort`                    | Kubernetes nodePort where the GUI is exposed                            | ``                        |
+| `service.annotations`                 | Service annotations for the GUI                                         | `{}`                      |
+| `service.labels`                      | Custom labels                                                           | `{}`                      |
+| `service.loadBalancerIP`              | Loadbalance IP for the GUI                                              | `{}`                      |
+| `service.loadBalancerSourceRanges`    | List of IP CIDRs allowed access to load balancer (if supported)         | None                      |
+| `service.externalTrafficPolicy`       | Set the externalTrafficPolicy in the Service to either Cluster or Local | `Cluster`                 |
+| `ingress.enabled`                     | Enables Ingress                                                         | `false`                   |
+| `ingress.annotations`                 | Ingress annotations                                                     | `{}`                      |
+| `ingress.path`                        | Ingress path                                                            | `/`                       |
+| `ingress.hosts`                       | Ingress accepted hostnames                                              | `chart-example.local`     |
+| `ingress.tls`                         | Ingress TLS configuration                                               | `[]`                      |
+| `persistence.enabled`                 | Use persistent volume to store data                                     | `false`                   |
+| `persistence.size`                    | Size of persistent volume claim                                         | `5Gi`                     |
+| `persistence.existingClaim`           | Use an existing PVC to persist data                                     | `nil`                     |
+| `persistence.storageClass`            | Type of persistent volume claim                                         | `-`                       |
+| `persistence.accessModes`             | Persistence access modes                                                | `ReadWriteOnce`           |
+| `persistence.subPath`                 | Mount a sub dir of the persistent volume                                | `nil`                     |
+| `resources`                           | CPU/Memory resource requests/limits                                     | `{}`                      |
+| `nodeSelector`                        | Node labels for pod assignment                                          | `{}`                      |
+| `tolerations`                         | Toleration labels for pod assignment                                    | `[]`                      |
+| `affinity`                            | Affinity settings for pod assignment                                    | `{}`                      |
+| `podAnnotations`                      | Key-value pairs to add as pod annotations                               | `{}`                      |
+| `deploymentAnnotations`               | Key-value pairs to add as deployment annotations                        | `{}`                      |
 
 Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,
 

charts/node-red/templates/deployment.yaml

@@ -44,14 +44,32 @@ spec:
             - name: http
               containerPort: 1880
               protocol: TCP
+          {{- if .Values.probes.liveness.enabled }}
           livenessProbe:
             httpGet:
-              path: {{ .Values.livenessProbePath }}
+              path: {{ .Values.probes.liveness.probePath }}
               port: http
+            initialDelaySeconds: {{ .Values.probes.liveness.initialDelaySeconds }}
+            failureThreshold: {{ .Values.probes.liveness.failureThreshold }}
+            timeoutSeconds: {{ .Values.probes.liveness.timeoutSeconds }}
+          {{- end }}
+          {{- if .Values.probes.readiness.enabled }}
           readinessProbe:
             httpGet:
-              path: {{ .Values.readinessProbePath }}
+              path: {{ .Values.probes.readiness.probePath }}
               port: http
+            initialDelaySeconds: {{ .Values.probes.readiness.initialDelaySeconds }}
+            failureThreshold: {{ .Values.probes.readiness.failureThreshold }}
+            timeoutSeconds: {{ .Values.probes.readiness.timeoutSeconds }}
+          {{- end }}
+          {{- if .Values.probes.startup.enabled }}
+          startupProbe:
+            httpGet:
+              path: {{ .Values.probes.startup.probePath }}
+              port: http
+            failureThreshold: {{ .Values.probes.startup.failureThreshold }}
+            periodSeconds: {{ .Values.probes.startup.periodSeconds }}
+          {{- end }}
           env:
             - name: FLOWS
               value: "{{ .Values.flows }}"

charts/node-red/values.yaml

@@ -15,8 +15,31 @@ fullnameOverride: ""
 
 serviceAccountName: ""
 
-livenessProbePath: /
-readinessProbePath: /
+# Probes configuration
+# ref: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-probes
+probes:
+  liveness:
+    # Indicates whether the container is running. If the liveness probe fails, the kubelet kills the container
+    # and the container is subjected to its restart policy.
+    enabled: true
+    probePath: /
+    initialDelaySeconds: 60
+    failureThreshold: 5
+    timeoutSeconds: 10
+  readiness:
+    # Indicates whether the container is ready to respond to requests.
+    enabled: true
+    probePath: /
+    initialDelaySeconds: 60
+    failureThreshold: 5
+    timeoutSeconds: 10
+  startup:
+    # Indicates whether the application within the container is started.
+    # All other probes are disabled if a startup probe is provided, until it succeeds.
+    enabled: false
+    probePath: /
+    failureThreshold: 30
+    periodSeconds: 10
 
 flows: "flows.json"
 safeMode: "false"

charts/nzbget/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v21.0
 description: NZBGet is a Usenet downloader client
 name: nzbget
-version: 6.3.0
+version: 6.4.0
 keywords:
   - nzbget
   - usenet
@@ -17,4 +17,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/nzbhydra2/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v3.4.3
 description: Usenet meta search
 name: nzbhydra2
-version: 4.3.0
+version: 4.4.0
 keywords:
   - nzbhydra2
   - usenet
@@ -17,4 +17,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/ombi/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 4.0.681
 description: Want a Movie or TV Show on Plex or Emby? Use Ombi!
 name: ombi
-version: 5.3.0
+version: 5.4.0
 keywords:
   - ombi
   - plex
@@ -21,4 +21,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/organizr/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: latest
 description: HTPC/Homelab Services Organizer
 name: organizr
-version: 2.3.0
+version: 2.4.0
 keywords:
   - organizr
 home: https://github.com/k8s-at-home/charts/tree/master/charts/organizr
@@ -16,4 +16,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/qbittorrent/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 4.3.0
 description: qBittorrent is a cross-platform free and open-source BitTorrent client
 name: qbittorrent
-version: 6.3.0
+version: 6.4.0
 keywords:
   - qbittorrent
   - torrrent
@@ -16,4 +16,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/radarr/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 3.0.0.3989
 description: A fork of Sonarr to work with movies à la Couchpotato
 name: radarr
-version: 7.3.0
+version: 7.4.0
 keywords:
   - radarr
   - torrent
@@ -18,4 +18,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/sabnzbd/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 3.1.0
 description: Free and easy binary newsreader
 name: sabnzbd
-version: 3.3.0
+version: 3.4.0
 keywords:
   - sabnzbd
   - usenet
@@ -17,4 +17,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/sonarr/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 3.0.4.993
 description: Smart PVR for newsgroup and bittorrent users
 name: sonarr
-version: 7.3.0
+version: 7.4.0
 keywords:
   - sonarr
   - torrent
@@ -18,4 +18,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/tautulli/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v2.6.1
 description: A Python based monitoring and tracking tool for Plex Media Server
 name: tautulli
-version: 5.3.0
+version: 5.4.0
 keywords:
   - tautulli
   - plex
@@ -17,4 +17,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0

charts/zwave2mqtt/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 4.0.6
 description: Fully configurable Zwave to MQTT gateway and Control Panel using NodeJS and Vue
 name: zwave2mqtt
-version: 5.0.0
+version: 5.1.0
 keywords:
   - zwave
   - mqtt
@@ -17,4 +17,4 @@ maintainers:
 dependencies:
   - name: common
     repository: https://k8s-at-home.com/charts/
-    version: ^1.4.0
+    version: ^1.5.0